This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
$cordovaOauth additions and bug fixes #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method to account for token secrets. fix how the browser is closed after making a post request to prevent quick close errors and browser flow cancel errors
pbernasconi
added a commit
that referenced
this pull request
Jan 14, 2015
feat(plugin:OAuth): Magento, ADFS, Vkontakte support + fix to Close browser only after promise was made to prevent inaccurate cancel login flow messages Add a timeout to the browser close. If a close attempt is made while the open transition is happening, it wont close. Adding a timeout is a workaround Lastly, the createSignature method has been updated to account for token secrets.
|
Looks good to me! thanks @nraboy |
|
No problem man. Ping me if someone ever has trouble with the Oauth stuff since I don't frequently visit the issue tracker. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge may seem large, but it isn't. I ended up copying all my code over because it was easier. Git picked up differences in spacing.
This request contains the following additions:
For bug fixes there were two types made that spanned across all providers:
Lastly, the createSignature method has been updated to account for token secrets.