fix(vue): add support for ionic supported browser versions #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
changed the title
sean-perkins
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of the box, Vite supports browser versions greater than what Ionic supports and does not support the
.browserslistrcfile.This PR installs the Vite Legacy plugin which gives support for legacy browsers and brings support for the
.browserslistrcfile.This discussion mentions the legacy plugin supporting browserlist because it uses Babel vs. ESBuild (in this linked article). There is a third party package here that adds browserlist support to ESBuild but doesn't seem necessary at this time since the legacy plugin includes it. Maybe once Ionic's browser support equals that of Vite, the legacy plugin can be dropped and the other plugin added. Hopefully by that time, Vite will support it :)
Vite supports:
Where as Ionic supports:
References