fix(react-vite,vue-vite): add vitest type reference #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @diegoazh thanks for the contribution! Can you provide a link to the documentation that suggests this approach? |
|
Sure @sean-perkins, you can check it here, on the second code example. Summarizing you can use the To avoid changing code because the error is only a type inference I decided to use the three slashes approach here. I think is clean and clear enough. |
|
do you need anything else @sean-perkins? |
|
What happens with this PR? How should I continue to merge this change? |
|
💪🏼 all tests passed successfully 🎉, let me know if I can help with anything else to merge this. Thank you. |
This change solves the TS error con the Vite config object following the Vitest documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves the TS error on the Vite config object following the Vitest documentation.