Merge pull request #11 from ehaynes99/master

Add null check before registering event handlers
ionic-team · Nov 8, 2019 · b99f399 · b99f399
2 parents 7479764 + 2e20239
commit b99f399
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/react-output-target/react-component-lib/utils/attachEventProps.ts b/packages/react-output-target/react-component-lib/utils/attachEventProps.ts
@@ -69,13 +69,15 @@ export function syncEvent(node: Element, eventName: string, newEventHandler: (e:
     node.removeEventListener(eventName, oldEventHandler);
   }
 
-  // Bind new listener.
-  node.addEventListener(
-    eventName,
-    (eventStore[eventName] = function handler(e: Event) {
-      newEventHandler.call(this, e);
-    }),
-  );
+  if (newEventHandler != null) {
+    // Bind new listener.
+    node.addEventListener(
+      eventName,
+      (eventStore[eventName] = function handler(e: Event) {
+        newEventHandler.call(this, e);
+      }),
+    );
+  }
 }
 
 function arrayToMap(arr: string[] | DOMTokenList) {