Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#81): change rxjs to event emitter #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

razvangeangu
Copy link
Contributor

@razvangeangu razvangeangu commented Nov 4, 2020

This will make sure the events are fired only once.

@jeserkin
Copy link

jeserkin commented Nov 5, 2020

Would @jthoms1 be so kind to review this PR?
Thank you.

@rsurjano
Copy link

throwing when compiling with angular

src/directives/angular-component-lib/utils.ts(27,45): error TS6133: 'el' is declared but its value is never read.

since el parameter is unused in new implementation

@klh klh mentioned this pull request Sep 20, 2021
@markacianfrani
Copy link

This fixes #81 . Currently any custom events that you listen for will fire twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants