fix(angular): type resolution with strict templates #209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the implementation pattern for event emitters in the Angular output target to solve inaccurate type detection for strict templates and Angular Language Service. This also eliminates the dependency on
rxjs
with the implementation pattern. Confirmed that this change does not regress the solution to prevent duplicate event emissions.Current version output:
Breaking change
Before this would work:
After, implementers will need to use
rxjs
to convert the DOM event:Fixes issue in Framework repo: ionic-team/ionic-framework#24245