-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): omit output related imports for components with no event #330
feat(angular): omit output related imports for components with no event #330
Conversation
Thanks for the PR! Is there an open issue on GitHub that you can link this to? |
Unfortunately there is no issue for that - if its required I'll create one. |
Yes, please create one. We require PRs to be linked to triaged issues before they can be merged. Thanks! |
Done - issue is created and linked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would love another set of eyes on it from someone who knows Angular a bit better.
@sean-perkins Mind taking a look when you get a chance? |
53a9480
to
f82db8c
Compare
f82db8c
to
d3279d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks for this contribution and great work 🎉
- feat(angular): omit output related imports for components with no events (#330)
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
It will always add
EventEmitter
andproxyOutputs
imports event if there are no components with event.Issue URL: Resolves #331
What is the new behavior?
Include import
EventEmitter
andproxyOutputs
only if there is at least one component with event.Does this introduce a breaking change?
Other information