-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(angular): recreate angular test app #358
Open
sean-perkins
wants to merge
9
commits into
main
Choose a base branch
from
sp/update-angular-example-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0312bf3
chore(angular): reinit test app infrastructure
sean-perkins 7ba1b18
chore: stop tracking generated files
sean-perkins 85f525b
chore: run prettier
sean-perkins ff477f7
Merge branch 'main' into sp/update-angular-example-app
sean-perkins da2195a
chore: build
sean-perkins b63962f
chore: prettier
sean-perkins 40e4302
chore: use version vs: file
sean-perkins 8c44125
chore: run tests not in watch mode
sean-perkins 89bc552
Merge branch 'main' into sp/update-angular-example-app
sean-perkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
packages/example-project/component-library-angular/.editorconfig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Editor configuration, see https://editorconfig.org | ||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 2 | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.ts] | ||
| quote_type = single | ||
|
|
||
| [*.md] | ||
| max_line_length = off | ||
| trim_trailing_whitespace = false |
46 changes: 46 additions & 0 deletions
46
packages/example-project/component-library-angular/.gitignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # See http://help.github.com/ignore-files/ for more about ignoring files. | ||
|
|
||
| # Compiled output | ||
| /dist | ||
| /tmp | ||
| /out-tsc | ||
| /bazel-out | ||
|
|
||
| # Node | ||
| /node_modules | ||
| npm-debug.log | ||
| yarn-error.log | ||
|
|
||
| # IDEs and editors | ||
| .idea/ | ||
| .project | ||
| .classpath | ||
| .c9/ | ||
| *.launch | ||
| .settings/ | ||
| *.sublime-workspace | ||
|
|
||
| # Visual Studio Code | ||
| .vscode/* | ||
| !.vscode/settings.json | ||
| !.vscode/tasks.json | ||
| !.vscode/launch.json | ||
| !.vscode/extensions.json | ||
| .history/* | ||
|
|
||
| # Miscellaneous | ||
| /.angular/cache | ||
| .sass-cache/ | ||
| /connect.lock | ||
| /coverage | ||
| /libpeerconnection.log | ||
| testem.log | ||
| /typings | ||
|
|
||
| # System files | ||
| .DS_Store | ||
| Thumbs.db | ||
|
|
||
| # Generated Files | ||
| src/directives/* | ||
| !src/directives/component-library.module.ts |
41 changes: 0 additions & 41 deletions
41
packages/example-project/component-library-angular/__tests__/my-checkbox.spec.ts
This file was deleted.
Oops, something went wrong.
45 changes: 0 additions & 45 deletions
45
packages/example-project/component-library-angular/__tests__/my-component.spec.ts
This file was deleted.
Oops, something went wrong.
126 changes: 0 additions & 126 deletions
126
packages/example-project/component-library-angular/__tests__/my-input.spec.ts
This file was deleted.
Oops, something went wrong.
45 changes: 0 additions & 45 deletions
45
packages/example-project/component-library-angular/__tests__/my-radio-group.spec.ts
This file was deleted.
Oops, something went wrong.
41 changes: 0 additions & 41 deletions
41
packages/example-project/component-library-angular/__tests__/my-radio.spec.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it that these tests (in
__tests__) are the ones mentioned in the PR summary?Does that mean that we don't plan on backfilling/adding tests to the new test app? Or that those will just be coming in a future PR?
EDIT: Ah, maybe https://github.com/ionic-team/stencil-ds-output-targets/pull/358/files#diff-1e2b03b89f374dd1898b69732368234ce6b7b290a8b6dcd58b3bf10166b192ac is the replacement or sorts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct on the referenced test file. Future PRs will fill in expected integrations we want to account for with the generated proxies. Currently we have too complex of components and tests, than are necessary for what the output targets are responsible for. This was likely because we just copied the component structure from Ionic Framework.
We can probably set up a nightly CI against Ionic Framework if we wanted that.