-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular-output-target): generate standalone components #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
changed the title
feat(angular-output-target): outputType configuration (#365)
feat(angular-output-target): generate standalone angular components
Jul 31, 2023
sean-perkins
changed the title
feat(angular-output-target): generate standalone angular components
feat(angular-output-target): generate standalone components
Jul 31, 2023
When updating Ionic Framework, this is the expected change to the Stencil config: angularOutputTarget({
componentCorePackage: '@ionic/core',
outputType: 'component',
directivesProxyFile: '../packages/angular/src/directives/proxies.ts',
directivesArrayFile: '../packages/angular/src/directives/proxies-list.ts',
excludeComponents: [
// overlays that accept user components
'ion-modal',
'ion-popover',
// navigation
'ion-router',
'ion-route',
'ion-route-redirect',
'ion-router-link',
'ion-router-outlet',
// tabs
'ion-tabs',
'ion-tab',
// auxiliar
'ion-picker-column',
],
}),
angularOutputTarget({
componentCorePackage: '@ionic/core',
outputType: 'standalone',
directivesProxyFile: '../packages/angular/src/directives/standalone.ts',
customElementsDir: 'components',
excludeComponents: [
// overlays that accept user components
'ion-modal',
'ion-popover',
// navigation
'ion-router',
'ion-route',
'ion-route-redirect',
'ion-router-link',
'ion-router-outlet',
// tabs
'ion-tabs',
'ion-tab',
// auxiliar
'ion-picker-column',
],
}), |
liamdebeasi
approved these changes
Jul 31, 2023
rwaskiewicz
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking merge-related ask
…scam (#368) * fix(angular-output-target): CE build only works with standalone and scam * chore: use util * refactor: use enum for output type * chore: prettier formatting * fix: weird vscode auto import
2 tasks
sean-perkins
added a commit
to ionic-team/ionic-framework
that referenced
this pull request
Aug 18, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> Ionic Framework currently only generates the lazy/hydrated Angular component wrappers for the web components. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Generates Angular standalone component wrappers for the web components, using the CE build. - Adds manual component wrapper for `ion-icon` with the CE build. - Migrates the `ion-back-button` and `ion-nav` to be manual component wrappers - Continues to generate the lazy/hydrated Angular component wrappers. - Refactors "NavDelegate" etc. language to `IonNav` to avoid exporting as and simplify navigating the code. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Related output targets PR: ionic-team/stencil-ds-output-targets#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: N/A
What is the new behavior?
Developers can generate standalone Angular component wrappers for their Stencil web components 🎉
outputType
option to the Angular output target for specifying the desired type of generated output. Defaults tocomponent
.includeSingleComponentAngularModules
option in favor ofoutputType: "scam"
.includeImportCustomElements
option in favor ofoutputType: "scam"
oroutputType: "standalone"
.Does this introduce a breaking change?
includeSingleComponentAngularModules
is removed, useoutputType: "scam"
instead.includeImportCustomElements
option is removed, either useoutputType: "scam"
oroutputType: "standalone"
.Other information
Dev-build:
@stencil/angular-output-target@0.7.2-dev.11691677969.1304fff5
Docs PR: ionic-team/stencil-site#1183