Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish-npm workflow uses local lerna version #371

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

sean-perkins
Copy link
Collaborator

@sean-perkins sean-perkins commented Aug 10, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: N/A

The publish npm workflow step uses Lerna 7 instead of the locally installed version.

What is the new behavior?

  • The composite action for publishing to npm uses the locally installed version of npm.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sean-perkins sean-perkins requested review from liamdebeasi and alicewriteswrongs and removed request for mapsandapps and tanner-reits August 10, 2023 15:53
@sean-perkins sean-perkins enabled auto-merge (squash) August 10, 2023 16:01
@sean-perkins sean-perkins merged commit 01c9c09 into main Aug 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants