Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): Export new option setCustomTagNameTransformer #421

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sdvg
Copy link

@sdvg sdvg commented Feb 26, 2024

The option allows to provide a function at runtime that modifies the tag names to be rendered by the React proxy components.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: #420

What is the new behavior?

  • Export method setCustomTagNameTransformer.
  • When defined, run function customTagNameTransformer to modify tag names to be rendered.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is just an early draft to show the idea and gather some feedback. Please let me know if this feature is something you'd like to merge and whether the general direction of the implementations is correct.

The option allows to provide a function at runtime that modifies the tag names to be rendered by the React proxy components.
@sdvg sdvg mentioned this pull request Feb 26, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant