Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): update @types/node to v16 #104

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

rwaskiewicz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

see 'new behavior' section

GitHub Issue Number: N/A

What is the new behavior?

this commit performs housekeeping that bumps the version of
@types/node to v16. the team has node 16 declared in the volta key of
package.json (and as a result use that to develop this library), but
prior to this commit had v14 of the typings installed. this commit
reconciles those two

Does this introduce a breaking change?

  • Yes
  • No

Testing

Typechecking in tests and build continue to pass

Other information

this commit performs housekeeping that bumps the version of
`@types/node` to v16. the team has node 16 declared in the volta key of
`package.json` (and as a result use that to develop this library), but
prior to this commit had v14 of the typings installed. this commit
reconciles those two
@rwaskiewicz rwaskiewicz marked this pull request as ready for review August 12, 2022 13:07
@rwaskiewicz rwaskiewicz requested a review from a team August 12, 2022 13:07
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy peasy

@rwaskiewicz rwaskiewicz merged commit ab4e446 into main Aug 23, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/update-node-types-16 branch August 23, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants