Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): increment min stencil version #109

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

rwaskiewicz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

this commit increments the minor version of @stencil/core in the peer
dependencies of the package. this change is a result of the stencil team
no longer officially supporting stencil v1.x

BREAKING CHANGE: Drops support for v1.X of Stencil. Stencil projects using
v1.x of @stencil/core will need to migrate to v2.x

Does this introduce a breaking change?

  • Yes
  • No

Applications using this library will need to migrate to Stencil v2.

Testing

  • Unit tests were run/passed

Other information

this commit increments the minor version of @stencil/core in the peer
dependencies of the package. this change is a result of the stencil team
no longer officially supporting stencil v1.x

BREAKING CHANGE: Drops support for v1.X of Stencil
@rwaskiewicz rwaskiewicz marked this pull request as ready for review August 19, 2022 17:06
@rwaskiewicz rwaskiewicz requested a review from a team August 19, 2022 17:06
Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just curious how you're gonna handle the breaking change. Should this go to a v2 branch? This is one of the packages we're going to continue maintaining, right?

@rwaskiewicz
Copy link
Member Author

@tanner-reits I'm going to cut a v2.0.0 release after this lands, rather than creating a v2 branch. That way, folks can upgrade with minimal friction (ideally), and we can signal that moving forward, the maintenance we do on this package will only be in conjunction with Stencil v2

Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍! sorry I missed the notification about this one for a bit

package.json Outdated
"@types/jest": "^26.0.15",
"@types/node": "^14.17.18",
"@types/sass": "^1.16.0",
"jest": "^26.6.3",
"np": "^7.0.0",
"prettier": "^2.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔡 💯 👍

@rwaskiewicz rwaskiewicz merged commit 27451e6 into main Aug 30, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/update-stencil-peer-v2 branch August 30, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants