Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): ignore unsupported typescript version #124

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

rwaskiewicz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): GitHub/Dependency Maintainence

What is the current behavior?

We receive Dependabot updates for packages we don't want to update ATM
GitHub Issue Number: N/A

What is the new behavior?

this commit updates the dependabot configuration to ignore the following packages:

  • typescript - ignore versions of typescript the Stencil ecosystem does not support

Does this introduce a breaking change?

  • Yes
  • No

Testing

Taken directly from Stencil core's dependabot config

Other information

this commit updates the dependabot manifest to
ignore v4.8 of typescript, which is unsupported by
the stencil ecosystem at this time
@rwaskiewicz rwaskiewicz marked this pull request as ready for review September 9, 2022 12:39
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner September 9, 2022 12:39
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwaskiewicz rwaskiewicz merged commit 59c5914 into main Sep 12, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz-patch-1 branch September 12, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants