chore(ci): upgrade ci for node 16 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update ci to run on every push to main, in addition to on every pull request. this helps bring us into parity with the functionality of stencil core at the time of this writing
this commit updates the run matrix to use node 16 instead of node 12. the latter is about to be deprecated by github actions, and we develop on node 16 today.
since the matrix for runtimes was a matrix of 1x1, remove it in favor of using setup-node. the latest version of the action can pull directly from volta, which is what we'll do
check out the code using actions/checkout, prior to running setup-node. this also upgrades actions/checkout from v1 to v3
this commit simply splits the existing install, build and tests commands into separate steps
rwaskiewicz
force-pushed
the
rwaskiewicz/port-ci
branch
from
f0febae
to
62bd4e4
Compare
|
Force merging since we're changing up CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Our CI process for this repository is quite old.
So old in fact, that it runs Node 12.
This is a blocker for upgrading/running CI on automatically created PRs such as #140, which rely on a newer version of Node.
GitHub Issue Number: N/A
What is the new behavior?
The primary change here is running on Node 16 over Node 12.
However, several upgrades were made while I was in the pipeline:
request. this helps bring us into parity with the functionality of
stencil core at the time of this writing (9be2e09)
Does this introduce a breaking change?
Testing
I tailed the logs to verify
Other information