Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(git): add ide's to gitignore #162

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

rwaskiewicz
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): git changes

What is the current behavior?

See new behavior section

GitHub Issue Number: N/A

What is the new behavior?

this commit adds the vs code and jetbrains ide settings directories to the project's gitignore file. this is being added as git attempts to surface these as available to check in, which is something we (as the stencil team) do not practice

Does this introduce a breaking change?

  • Yes
  • No

Testing

N/A

Other information

this commit adds the vs code and jetbrains ide settings directories to
the project's gitignore file. this is being added as git attempts to
surface these as available to check in, which is something we (as the
stencil team) do not practice
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwaskiewicz rwaskiewicz merged commit 0a9c8db into main Nov 16, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/add-ides-to-gitignore branch November 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants