Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): upgrade typescript to v4.9.4 #163

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Nov 16, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

See new behavior section
GitHub Issue Number: N/A

What is the new behavior?

this commit increments the supported version of typescript to v4.9.4.

this commit also updates dependabot's manifest to ignore v4.10/5.0 of typescript,
as it is not used in the rest of the Stencil ecosystem at this time

Does this introduce a breaking change?

  • Yes
  • No

Testing

In addition to unit tests and build the continuing to pass, I also did a diff on the output for this branch against the HEAD of main. For main:

npm ci && \
npm run build && \
mv dist dist_main

And on this branch:

npm ci && \
npm run build

Finally, diff the two

diff -r dist dist_main

Other information

@rwaskiewicz rwaskiewicz changed the title chore(deps-dev): upgrade typescript to v4.8.4 chore(deps-dev): upgrade typescript to v4.9.4 Dec 8, 2022
@rwaskiewicz
Copy link
Member Author

@tanner-reits / @alicewriteswrongs I ended up bumping this to 4.9, mind taking another look?

this commit increments the supported version of typescript to v4.8.4.
version 4.9 will be supported at a later date when that version of the
language is used in the core compiler.

this commit also updates dependabot's manifest to ignore v4.9 of
typescript for the same reason
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwaskiewicz rwaskiewicz enabled auto-merge (squash) December 12, 2022 21:47
@rwaskiewicz rwaskiewicz merged commit 9338068 into main Dec 12, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/ts-4.8 branch December 13, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants