Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): support stencil v3 #198

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Jan 10, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, the package declares a need for Stencil version >=2.0.0. When we install the v3 beta, we get error warnings that we violate this constraint

GitHub Issue Number: N/A

What is the new behavior?

this commit bumps the values of package.json#peerDependencies to accept v3.0.0 of stencil.

Does this introduce a breaking change?

  • Yes
  • No

Testing

This commit was validated in the Ionic Framework with the changes that @alicewriteswrongs made in ionic-team/stencil-ds-output-targets#318. To verify this yourself:

  1. Checkout this branch, npm ci && npm run build && npm pack <- Also helps validate the changes to the manifest and lockfile are semi-well formed (would show an error message if there was a parse error)
  2. Checkout Alice's branch and run:
    2.1. npm run bootstrap && npm run build
    2.2. pushd packages/angular-output-target && npm pack && popd
    2.3. pushd packages/react-output-target && npm pack && popd
    2.4. pushd packages/vue-output-target && npm pack && popd
  3. Checkout the Ionic Framework
    3.1. cd core && npm ci
    3.2. npm i @stencil/core@v3-latest [stencil-sass-tarball] [angular-wrapper-tarball] [react-wrapper-tarball] [vue-wrapper-tarball]
    3.3. Observe no errors in the install

Other information

@rwaskiewicz rwaskiewicz marked this pull request as ready for review January 10, 2023 15:07
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner January 10, 2023 15:07
this commit bumps the values of `package.json#peerDependencies` to
accept v3.0.0 of stencil.
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray for no errors!

@rwaskiewicz rwaskiewicz merged commit ef7dd4a into main Jan 10, 2023
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/bump-stencil-sass-for-stencil3 branch January 10, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants