Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update stencil versions run post-v3 #212

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Jan 26, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): CI

What is the current behavior?

We run CI against more Stencil versions than needed
GitHub Issue Number: N/A

What is the new behavior?

this commit updates the versions of stencil that ci runs against, following the v3 release of stencil & updating the dev dependency on stencil to v3 in #210

the 'v3-next' version has been removed, as that tag resolves to stencil v3.0.0

the 'latest' verison has been removed, as it now resolves to the same version as 'DEFAULT'

Does this introduce a breaking change?

  • Yes
  • No

Testing

Tailed CI logs

Other information

Will need to update the GitHub required checks prior to this landing

this commit updates the versions of stencil that ci runs against,
following the v3 release of stencil & updating the dev dependency on
stencil to v3 in #210

the 'v3-next' version has been removed, as that tag resolves to stencil
v3.0.0

the 'latest' verison has been removed, as it now resolves to the same
version as 'DEFAULT'
@rwaskiewicz rwaskiewicz marked this pull request as ready for review January 26, 2023 16:38
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner January 26, 2023 16:38
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rwaskiewicz rwaskiewicz enabled auto-merge (squash) January 26, 2023 19:42
@rwaskiewicz rwaskiewicz merged commit b66d31f into main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants