refactor(diagnostics): replace substr calls w substring #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
This package uses a deprecated
substr
functionGitHub Issue Number: N/A
What is the new behavior?
this commit updates diagnostic generation to use
substring
instead ofthe deprecated
substr
function. the original calls tosubstr
usedonly a single parameter, the start index of the substring to grab. this
allowed for a simple swap of the two calls
Does this introduce a breaking change?
Testing
I didn't test this 馃槵
Other information
Dependent on #225