Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(github): add pull request template #76

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

rwaskiewicz
Copy link
Member

this commit adds a pull request template to the repository. it initially
takes the request template from https://github.com/ionic-team/create-stencil/blob/43b4128a91e1870d76bb2768a2ea5266e18dcbdc/.github/PULL_REQUEST_TEMPLATE.md

- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
- [ ] Build (`npm run build`) was run locally and any changes were pushed
- [ ] Tests (`npm test`) were run locally and passed
- [ ] Prettier (`npm run prettier`) was run locally and passed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I corrected the command in #77

Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 👍

@rwaskiewicz rwaskiewicz merged commit 6025482 into main Jul 8, 2022
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/pr-template branch July 8, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants