Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydrate App: Incorrect/Missing renderToString Options #669

Open
guidoknoll opened this issue Aug 4, 2020 · 0 comments
Open

Hydrate App: Incorrect/Missing renderToString Options #669

guidoknoll opened this issue Aug 4, 2020 · 0 comments

Comments

@guidoknoll
Copy link

The renderToString Options in the Guides/Hydrate App Chapter are incorrect and not well documented.

The afterHydrate and beforeHydrate Options with type boolean already seemed a bit off to me so i analyzed the hydrate build. These are functions with the mocked document as a parameter, so that you can modify the mocked window object before rendering for example.

The other options seem correct and self-explanatory to me.

I'll try opening a PR the next days!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guidoknoll