Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy config docs #73

Closed
Phhansen opened this issue Oct 11, 2017 · 2 comments
Closed

Update copy config docs #73

Phhansen opened this issue Oct 11, 2017 · 2 comments
Assignees
@jgw96

Comments

@Phhansen
Copy link
Contributor

After digging through some code answering a question on slack i figured the documentation regarding the copy configuration could do with a little more explanation.

I´ll be happy to make a PR adding a little more information regarding the structure and properties required.
@jgw96
Copy link
Contributor

jgw96 commented Oct 12, 2017

@Phhansen feel free to do a PR, were always completely open to contributions! (:

Phhansen added a commit to Phhansen/stencil-site that referenced this issue Oct 13, 2017
@Phhansen
docs(copy): add better description to copy config (ionic-team#73)
103d978
@Phhansen Phhansen mentioned this issue Oct 13, 2017
Merged
jgw96 pushed a commit that referenced this issue Oct 19, 2017
@Phhansen @jgw96
docs(copy): add better description to copy config (#73) (#75)
39f35a6
@jgw96
Copy link
Contributor

jgw96 commented Nov 1, 2017

Going to close this for now as the PR was merged. Thanks again @Phhansen !

@jgw96 jgw96 closed this as completed Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgw96 jgw96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Phhansen @jgw96