Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(redux): remove redux docs #1056

Merged
merged 6 commits into from
Mar 1, 2023
Merged

docs(redux): remove redux docs #1056

merged 6 commits into from
Mar 1, 2023

Conversation

tanner-reits
Copy link
Member

Removes the docs for Redux and Stencil Redux. Updates our redirects to point these URLs to the archived Stencil Redux repo

@vercel
Copy link

vercel bot commented Feb 28, 2023

Deployment failed with the following error:

Redirect at index 24 has invalid `source` regular expression "*/redux(/)?".

Learn More: https://vercel.link/invalid-route-source-pattern

@tanner-reits tanner-reits marked this pull request as draft February 28, 2023 16:38
@vercel
Copy link

vercel bot commented Feb 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 10:15PM (UTC)

@tanner-reits tanner-reits marked this pull request as ready for review February 28, 2023 16:42
@tanner-reits
Copy link
Member Author

Not sure why CI is falling over since I didn't change dependencies at all. I ran the check locally and everything passed there

alicewriteswrongs
alicewriteswrongs approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alicewriteswrongs alicewriteswrongs mentioned this pull request Feb 28, 2023
Merged
rwaskiewicz
rwaskiewicz requested changes Feb 28, 2023
View reviewed changes
Copy link
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you rebase off of main and rm these from the versioned_docs/version-v3.1/ dir please?

@alicewriteswrongs
Copy link
Contributor

To get CI to pass we'll need another rebase after #1057

@tanner-reits
Copy link
Member Author

All is well now

@tanner-reits tanner-reits merged commit 130b97b into main Mar 1, 2023
@tanner-reits tanner-reits deleted the treits/docs/remove-redux-docs branch March 1, 2023 14:04
@alicewriteswrongs alicewriteswrongs mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaskiewicz rwaskiewicz rwaskiewicz approved these changes

@alicewriteswrongs alicewriteswrongs alicewriteswrongs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tanner-reits @alicewriteswrongs @rwaskiewicz