-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(component): add note on limitation of rendering referenced components #1313
docs(component): add note on limitation of rendering referenced components #1313
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1f5ea5f
to
20dbcd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question
versioned_docs/version-v4.1/components/functional-components.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I'm good with either verbiage - either works IMO
Co-authored-by: Alice Pote <alice.writes.wrongs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me with the updated copy, we just want to propagate that to all of our files
@alicewriteswrongs duh' .. updated all other locations too. |
Based on investigations done in ionic-team/stencil#3953 we don't recommend importing components directly and instead just use the component tags.