Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(component): add note on limitation of rendering referenced components #1313

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

christian-bromann
Copy link
Member

Based on investigations done in ionic-team/stencil#3953 we don't recommend importing components directly and instead just use the component tags.

@christian-bromann christian-bromann requested a review from a team as a code owner January 9, 2024 19:01
@christian-bromann christian-bromann requested review from rwaskiewicz and alicewriteswrongs and removed request for a team January 9, 2024 19:01
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:18pm

@christian-bromann christian-bromann force-pushed the cb/document-dynamic-render-limitation branch from 1f5ea5f to 20dbcd1 Compare January 9, 2024 19:28
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

Copy link
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'm good with either verbiage - either works IMO

Co-authored-by: Alice Pote <alice.writes.wrongs@gmail.com>
Copy link
Member

@alicewriteswrongs alicewriteswrongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me with the updated copy, we just want to propagate that to all of our files

@christian-bromann
Copy link
Member Author

@alicewriteswrongs duh' .. updated all other locations too.

@christian-bromann christian-bromann merged commit de1b4f5 into main Jan 22, 2024
5 checks passed
@christian-bromann christian-bromann deleted the cb/document-dynamic-render-limitation branch January 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants