chore(repo): update ci workflow post-stencil v4 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit updates the stencil version matrix in the main ci workflow to: - no longer use "latest" and "v4-next", now that stencil v4 is out - explicitly run with stencil v3, v4 as a result, we should expect four runs of this workflow to run in parallel - one for stencil v2, v3, & v4, as well as one for the version of stencil that is installed in package-lock.json. there is expected to be some overlap between the latest two major versions and "latest" (the latter will point to either v3 or v4, depending on the state of the repo)
tanner-reits
approved these changes
Jun 27, 2023
alicewriteswrongs
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
We had certain configs added to the repo's CI for Stencil v4 dev that we no longer need
GitHub Issue Number: N/A
What is the new behavior?
this commit updates the stencil version matrix in the main ci workflow to:
as a result, we should expect four runs of this workflow to run in parallel - one for stencil v2, v3, & v4, as well as one for the version of stencil that is installed in package-lock.json. there is expected to be some overlap between the latest two major versions and "latest" (the latter will point to either v3 or v4, depending on the state of the repo)
Does this introduce a breaking change?
Testing
CI should continue to pass
Other information
Will have to update gating on CI as a part of this PR