Skip to content

Commit

Permalink
feat(output_targets): remove legacy angular target (#3493)
Browse files Browse the repository at this point in the history
this commit removes the legacy angular output target from the core
compiler. stencil no longer places framework output targets within the
compiler directly. instead, developers should be using the angular
output target that is maintained by the stencil/ionic framework teams,
located at https://www.npmjs.com/package/@stencil/angular-output-target

Documentation for getting started with the Angular Framework Wrapper can
be found at: https://stenciljs.com/docs/angular

BREAKING CHANGE: Removed the legacy Angular output target. Users should
migrate to https://www.npmjs.com/package/@stencil/angular-output-target
  • Loading branch information
rwaskiewicz committed Jan 25, 2023
1 parent 674bf51 commit 3b480c6
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 297 deletions.
2 changes: 0 additions & 2 deletions src/compiler/config/outputs/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
isValidConfigOutputTarget,
VALID_CONFIG_OUTPUT_TARGETS,
} from '../../output-targets/output-utils';
import { validateAngular } from './validate-angular';
import { validateCollection } from './validate-collection';
import { validateCustomElement } from './validate-custom-element';
import { validateCustomElementBundle } from './validate-custom-element-bundle';
Expand Down Expand Up @@ -43,7 +42,6 @@ export const validateOutputTargets = (config: d.ValidatedConfig, diagnostics: d.
...validateWww(config, diagnostics, userOutputs),
...validateDist(config, userOutputs),
...validateDocs(config, diagnostics, userOutputs),
...validateAngular(config, userOutputs),
...validateStats(config, userOutputs),
];

Expand Down
33 changes: 0 additions & 33 deletions src/compiler/config/outputs/validate-angular.ts

This file was deleted.

2 changes: 0 additions & 2 deletions src/compiler/output-targets/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { outputCustomElements } from './dist-custom-elements';
import { outputCustomElementsBundle } from './dist-custom-elements-bundle';
import { outputHydrateScript } from './dist-hydrate-script';
import { outputLazy } from './dist-lazy/lazy-output';
import { outputAngular } from './output-angular';
import { outputDocs } from './output-docs';
import { outputLazyLoader } from './output-lazy-loader';
import { outputTypes } from './output-types';
Expand All @@ -29,7 +28,6 @@ export const generateOutputTargets = async (
invalidateRollupCaches(compilerCtx);

await Promise.all([
outputAngular(config, compilerCtx, buildCtx),
outputCopy(config, compilerCtx, buildCtx),
outputCollection(config, compilerCtx, buildCtx, changedModuleFiles),
outputCustomElements(config, compilerCtx, buildCtx),
Expand Down
245 changes: 0 additions & 245 deletions src/compiler/output-targets/output-angular.ts

This file was deleted.

4 changes: 0 additions & 4 deletions src/compiler/output-targets/output-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ export const isOutputTargetCopy = (o: d.OutputTarget): o is d.OutputTargetCopy =

export const isOutputTargetDistLazy = (o: d.OutputTarget): o is d.OutputTargetDistLazy => o.type === DIST_LAZY;

export const isOutputTargetAngular = (o: d.OutputTarget): o is d.OutputTargetAngular => o.type === ANGULAR;

export const isOutputTargetDistLazyLoader = (o: d.OutputTarget): o is d.OutputTargetDistLazyLoader =>
o.type === DIST_LAZY_LOADER;

Expand Down Expand Up @@ -70,7 +68,6 @@ export const isOutputTargetDistTypes = (o: d.OutputTarget): o is d.OutputTargetD
export const getComponentsFromModules = (moduleFiles: d.Module[]) =>
sortBy(flatOne(moduleFiles.map((m) => m.cmps)), (c: d.ComponentCompilerMeta) => c.tagName);

export const ANGULAR = 'angular';
export const COPY = 'copy';
export const CUSTOM = 'custom';
export const DIST = 'dist';
Expand Down Expand Up @@ -115,7 +112,6 @@ export const VALID_CONFIG_OUTPUT_TARGETS = [
DOCS_CUSTOM,

// MISC
ANGULAR,
COPY,
CUSTOM,
STATS,
Expand Down
11 changes: 0 additions & 11 deletions src/declarations/stencil-public-compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2071,16 +2071,6 @@ export interface OutputTargetBase {

export type OutputTargetBuild = OutputTargetDistCollection | OutputTargetDistLazy;

export interface OutputTargetAngular extends OutputTargetBase {
type: 'angular';

componentCorePackage: string;
directivesProxyFile?: string;
directivesArrayFile?: string;
directivesUtilsFile?: string;
excludeComponents?: string[];
}

export interface OutputTargetCopy extends OutputTargetBase {
type: 'copy';

Expand Down Expand Up @@ -2173,7 +2163,6 @@ export interface OutputTargetWww extends OutputTargetBase {
}

export type OutputTarget =
| OutputTargetAngular
| OutputTargetCopy
| OutputTargetCustom
| OutputTargetDist
Expand Down

0 comments on commit 3b480c6

Please sign in to comment.