feat(node): drop node 12 support (#3302)

this commit drops node 12 support from stencil by:

- removing node 12 from main CI workflow
- updating minimum, recommended versions for running stencil
to v14.5 and 16.14, respectively
- updating volta versions of node, npm for our karma tests
- updating the 'engines' field of package.json
- setting the minimum default version of node in compiler
- adding todos to the codebase for future (Node 18+) work that will
be caused by future deprecations

STENCIL-176: Drop Node 12 Support

BREAKING CHANGE: Node v14+ is now required by Stencil

.github/workflows/main.yml

@@ -13,7 +13,7 @@ jobs:
   build_and_test:
     strategy:
       matrix:
-        node: ['12', '14', '16']
+        node: ['14', '16']
         os: ['ubuntu-latest', 'windows-latest']
 
     name: Node ${{ matrix.node }} on ${{ matrix.os }}
@@ -59,7 +59,7 @@ jobs:
 
       - name: Unload build artifacts
         uses: actions/upload-artifact@v2
-        if: matrix.os == 'ubuntu-latest' && matrix.node == '12'
+        if: matrix.os == 'ubuntu-latest' && matrix.node == '14'
         with:
           name: stencil-build
           path: stencil-build.tgz

bin/stencil

@@ -1,9 +1,9 @@
 #!/usr/bin/env node
 'use strict';
 
-var minimumVersion = '12.10';
+var minimumVersion = '14.5';
 var futureDeprecationMinVersion = '14.0';
-var recommendedVersion = '14.5';
+var recommendedVersion = '16.4';
 var currentVersion = process.versions.node;
 
 function isNodeLT(v) {
@@ -33,7 +33,7 @@ if (isNodeLT(futureDeprecationMinVersion)) {
       currentVersion +
       ", however Stencil's recommendation is v" +
       recommendedVersion +
-      '.0 or greater. Note that future versions of Stencil will eventually remove support for non-LTS Node versions and an Active LTS version is recommended (https://nodejs.org/en/about/releases/).\n'
+      '.0 or greater. Note that future versions of Stencil will eventually remove support for older Node versions and an Active LTS version is recommended (https://nodejs.org/en/about/releases/).\n'
   );
 }
 

package.json

@@ -130,7 +130,7 @@
     "ws": "7.4.6"
   },
   "engines": {
-    "node": ">=12.10.0",
+    "node": ">=14.10.0",
     "npm": ">=6.0.0"
   },
   "repository": {

scripts/bundles/helpers/compiler-cjs-intro.js

@@ -31,6 +31,6 @@ if (!process.platform) {
   process.platform = 'stencil';
 }
 if (!process.version) {
-  process.version = 'v12.0.0';
+  process.version = 'v14.0.0';
 }
 process.browser = !!globalThis.location;

src/sys/node/node-sys.ts

@@ -344,6 +344,9 @@ export function createNodeSys(c: { process?: any } = {}) {
       return new Promise((resolve) => {
         const recursive = !!(opts && opts.recursive);
         if (recursive) {
+          // TODO(STENCIL-410): In a future version of Node, `force: true` will be required in the options argument. At
+          // the time of this writing, Stencil's Node typings do not support this option.
+          // https://nodejs.org/docs/latest-v16.x/api/deprecations.html#dep0147-fsrmdirpath--recursive-true-
           fs.rmdir(p, { recursive: true }, (err) => {
             resolve({
               basename: path.basename(p),
@@ -372,6 +375,9 @@ export function createNodeSys(c: { process?: any } = {}) {
       try {
         const recursive = !!(opts && opts.recursive);
         if (recursive) {
+          // TODO(STENCIL-410): In a future version of Node, `force: true` will be required in the options argument. At
+          // the time of this writing, Stencil's Node typings do not support this option.
+          // https://nodejs.org/docs/latest-v16.x/api/deprecations.html#dep0147-fsrmdirpath--recursive-true-
           fs.rmdirSync(p, { recursive: true });
         } else {
           fs.rmdirSync(p);

test/karma/package.json

@@ -46,7 +46,7 @@
     "workbox-build": "4.3.1"
   },
   "volta": {
-    "node": "12.22.7",
-    "npm": "6.14.15"
+    "node": "14.5.0",
+    "npm": "6.14.16"
   }
 }