Skip to content

Commit

Permalink
chore(deps): add support for node 20
Browse files Browse the repository at this point in the history
This adds support for node 20 by:

- updating CI
- upgrading `@types/node`
- setting the version for Volta
- configuring the renovate bot
- making a small change to fix an issue with one test
  • Loading branch information
alicewriteswrongs committed May 16, 2023
1 parent 5324cea commit 899aac6
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16', '18']
node: ['14', '16', '18', '20']
os: ['ubuntu-20.04', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-component-starter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16', '18']
node: ['14', '16', '18', '20']
os: ['ubuntu-latest', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16', '18']
node: ['14', '16', '18', '20']
os: ['ubuntu-20.04', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['14', '16', '18']
node: ['14', '16', '18', '20']
os: ['ubuntu-20.04', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"@types/inquirer": "^7.3.1",
"@types/jest": "^27.0.3",
"@types/listr": "^0.14.4",
"@types/node": "^18.14.0",
"@types/node": "^20.1.1",
"@types/pixelmatch": "^5.2.4",
"@types/pngjs": "^6.0.1",
"@types/prompts": "^2.0.9",
Expand Down Expand Up @@ -149,7 +149,7 @@
],
"prettier": "@ionic/prettier-config",
"volta": {
"node": "18.16.0",
"node": "20.1.0",
"npm": "9.6.6"
}
}
2 changes: 1 addition & 1 deletion renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
packageRules: [
{
matchPackageNames: ['@types/node'],
allowedVersions: '<19.0.0',
allowedVersions: '<21.0.0',
},
{
// TODO(STENCIL-710): Increment this value as a part of updating TypeScript
Expand Down
2 changes: 1 addition & 1 deletion src/utils/test/util.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe('util', () => {
const expectedDiagnostic: d.Diagnostic = stubDiagnostic({
absFilePath: mockPackageJsonPath,
header: 'Error Parsing JSON',
messageText: 'Unexpected string in JSON at position 13', // due to missing colon in input
messageText: expect.stringMatching(/.*in JSON at position 13$/),
type: 'build',
});

Expand Down

0 comments on commit 899aac6

Please sign in to comment.