Skip to content

Commit

Permalink
chore(validation): remove unneeded path arg (#5628)
Browse files Browse the repository at this point in the history
remove `rootDir` from the validation of `normalizePath` for `dist-custom-elements`.
we expect that users will be able to select their own directory for typings, even
if they appear outside of the `rootDir`. this change aligns this output target
with the rest of the output target checks in this file.
  • Loading branch information
PebblerWon committed Apr 22, 2024
1 parent 1a64abb commit 913b621
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -50,7 +50,7 @@ export const PRIMARY_PACKAGE_TARGET_CONFIGS = {
normalizePath(relative(rootDir, join(outputTargetDir, 'index.js'))),
getTypesPath: (rootDir: string, outputTargetConfig: d.OutputTargetDistCustomElements) => {
return outputTargetConfig.generateTypeDeclarations
? normalizePath(relative(rootDir, join(rootDir, outputTargetConfig.dir!, 'index.d.ts')))
? normalizePath(relative(rootDir, join(outputTargetConfig.dir!, 'index.d.ts')))
: null;
},
},
Expand Down

0 comments on commit 913b621

Please sign in to comment.