fix(bundles): add sideEffects false to package

ionic-team · Jan 12, 2021 · d3bc9e6 · d3bc9e6
1 parent 9396d81
commit d3bc9e6
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/scripts/bundles/internal-app-data.ts b/scripts/bundles/internal-app-data.ts
@@ -20,6 +20,7 @@ export async function internalAppData(opts: BuildOptions) {
     main: 'index.cjs',
     module: 'index.js',
     types: 'index.d.ts',
+    sideEffects: false
   });
 
   const internalAppDataBundle: RollupOptions = {

diff --git a/scripts/bundles/internal-platform-client.ts b/scripts/bundles/internal-platform-client.ts
@@ -26,6 +26,7 @@ export async function internalClient(opts: BuildOptions) {
     name: '@stencil/core/internal/client',
     description: 'Stencil internal client platform to be imported by the Stencil Compiler and internal runtime. Breaking changes can and will happen at any time.',
     main: 'index.js',
+    sideEffects: false,
   });
 
   const internalClientBundle: RollupOptions = {

diff --git a/scripts/bundles/internal.ts b/scripts/bundles/internal.ts
@@ -27,6 +27,7 @@ export async function internal(opts: BuildOptions) {
     description: 'Stencil internals only to be imported by the Stencil Compiler. Breaking changes can and will happen at any time.',
     main: 'index.js',
     types: 'index.d.ts',
+    sideEffects: false,
   });
 
   const clientPlatformBundle = await internalClient(opts);

diff --git a/scripts/bundles/mock-doc.ts b/scripts/bundles/mock-doc.ts
@@ -24,6 +24,7 @@ export async function mockDoc(opts: BuildOptions) {
     main: 'index.cjs',
     module: 'index.js',
     types: 'index.d.ts',
+    sideEffects: false,
   });
 
   const esOutput: OutputOptions = {

diff --git a/scripts/utils/write-pkg-json.ts b/scripts/utils/write-pkg-json.ts
@@ -35,7 +35,7 @@ export function writePkgJson(opts: BuildOptions, pkgDir: string, pkgData: Packag
   fs.writeFileSync(path.join(pkgDir, 'package.json'), JSON.stringify(formatedPkg, null, 2) + '\n');
 }
 
-const PROPS_ORDER = ['name', 'version', 'description', 'main', 'module', 'browser', 'types', 'exports', 'type', 'private'];
+const PROPS_ORDER = ['name', 'version', 'description', 'bin', 'main', 'module', 'browser', 'types', 'exports', 'type', 'files', 'private', 'sideEffects'];
 
 export interface PackageData {
   name: string;
@@ -57,4 +57,5 @@ export interface PackageData {
   repository?: any;
   files?: string[];
   bin?: { [key: string]: string };
+  sideEffects?: false;
 }