Skip to content

Commit

Permalink
feat(declarations): add popover attributes to JSX declarations (#5064)
Browse files Browse the repository at this point in the history
* feat(declarations): add popover attributes

* align types with lib.dom.ts types

* add comment
  • Loading branch information
tanner-reits committed Nov 15, 2023
1 parent 91cfa2c commit f73aa14
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions src/declarations/stencil-public-runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,11 @@ export namespace JSXBase {
name?: string;
type?: string;
value?: string | string[] | number;

// popover
popoverTargetAction?: string;
popoverTargetElement?: Element | null;
popoverTarget?: string;
}

export interface CanvasHTMLAttributes<T> extends HTMLAttributes<T> {
Expand Down Expand Up @@ -1074,6 +1079,11 @@ export namespace JSXBase {
webkitdirectory?: boolean;
webkitEntries?: any;
width?: number | string;

// popover
popoverTargetAction?: string;
popoverTargetElement?: Element | null;
popoverTarget?: string;
}

export interface KeygenHTMLAttributes<T> extends HTMLAttributes<T> {
Expand Down Expand Up @@ -1365,6 +1375,11 @@ export namespace JSXBase {
tabIndex?: number;
tabindex?: number | string;
title?: string;
// These types don't allow you to use popover as a boolean attribute
// so you can't write HTML like `<div popover>` and get the default value.
// Developer must explicitly specify one of the valid popover values or it will fallback
// to `manual` (following the HTML spec).
popover?: string | null;

// Unknown
inputMode?: string;
Expand Down

0 comments on commit f73aa14

Please sign in to comment.