Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip puppeteer install #1529

Closed
1 of 3 tasks
romulocintra opened this issue May 15, 2019 · 1 comment
Closed
1 of 3 tasks

Skip puppeteer install #1529

romulocintra opened this issue May 15, 2019 · 1 comment
Labels
ionitron: stale issue This issue has not seen any activity for a long period of time

Comments

@romulocintra
Copy link
Contributor

Stencil version:

 @stencil/core@x.x.x All

I'm submitting a:

Current behavior:

Every time I run e2e tests Stencil installs puppeteer , even if I have it installed globally or under project structure(monorepo).

Expected behavior:

I would like to have the alternative to setup 2 things :

  1. SkipInstall to not install puppeteer.
  • I can use puppeteer-core in CI env
  • I can use inside monorepo
  1. executablePath configure on stencil.config.ts the path to chrome I would like to execute same as :
const browser = await puppeteer.launch({executablePath: '/path/to/Chrome'});

Use Cases :

  • Running e2e tests on CI
  • Want to use a different version of chrome and not chromium
  • Customized npm install puppeteer-core@chrome-71
@ionitron-bot ionitron-bot bot added the triage label May 15, 2019
@romulocintra romulocintra mentioned this issue May 18, 2019
Closed
@ionitron-bot ionitron-bot bot added the ionitron: stale issue This issue has not seen any activity for a long period of time label Jun 20, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Jun 20, 2019

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Jun 20, 2019
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jun 20, 2019
manucorporat added a commit that referenced this issue Jun 25, 2019
@manucorporat
fix(testing): Skip puppeteer install
01f0a93 
fixes #1529

Squashed commit of the following:

commit 8e57e7e
Author: Romulo Cintra <romulocintra@gmail.com>
Date:   Thu May 23 15:44:07 2019 +0200

    feat: conditional Lazyload of puppeteer

commit c58e790
Merge: 1125d3c c4d7c0d
Author: Romulo Cintra <romulocintra@gmail.com>
Date:   Thu May 23 15:21:13 2019 +0200

    Merge branch 'master' of github.com:ionic-team/stencil into feature/skip-install-puppeteer

commit 1125d3c
Author: Romulo Cintra <romulocintra@gmail.com>
Date:   Sat May 18 22:41:35 2019 +0200

    wip: skip puppeteer install
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
ionitron: stale issue This issue has not seen any activity for a long period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip puppeteer install romulocintra/stencil
2 participants
@romulocintra @simonhaenisch