feat: Disable the dependencies part of the markdown docs. #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down. Removed the footer: string argument from generateMarkdown. Refactored generateMarkdown to check if the readmeOutput.dependencies property is set. - For backwards compatibility the dependencies will still be generated if the property is undefined.
manucorporat
reviewed
Feb 2, 2020
manucorporat
reviewed
Feb 2, 2020
Co-Authored-By: Manu MA <manu.valladolid@gmail.com>
|
Disclosure: I'm on the same team as @eNepper. @adamdbradley Any chance you can review this? We'd love to see this change merged. Thanks! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a dependencies: boolean property to OutputTargetDocsReadme, this allows the developer to disable the dependencies part of the markdown readme.md file.
If the property is undefined the dependencies will still be rendered.