Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputHTMLAttributes type missing directory and webkitdirectory #2218

Closed
cramshaw opened this issue Feb 25, 2020 · 1 comment
Closed

InputHTMLAttributes type missing directory and webkitdirectory #2218

cramshaw opened this issue Feb 25, 2020 · 1 comment
Labels

Comments

@cramshaw
Copy link

cramshaw commented Feb 25, 2020

Stencil version:

 @stencil/core@1.8.7

I'm submitting a:

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

InputHTMLAttributes type is missing directory and webkitdirectory. You can find the type declaration here.

export interface InputHTMLAttributes<T> extends HTMLAttributes<T> {

This allows file inputs to select a folder, rather than just a single file.

Expected behavior:

InputHTMLAttributes type should allow me to set directory and webkitdirectory attributes on input.

Steps to reproduce:

Create a component containing an input thus:
<input type="file" directory webkitdirectory />

Related code:

// insert any relevant code here

Other information:

I believe it should just require adding to the InputHTMLAttributes type. Let me know if I can do anything else to help! Thanks!

@ionitron-bot ionitron-bot bot added the triage label Feb 25, 2020
adamdbradley added a commit that referenced this issue Feb 25, 2020
@adamdbradley
Copy link
Contributor

Updated thanks, but did not add directory since it's not listed by MDN: https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants