Hardcoded app load timeout failing tests intermittently

[carl-ellis]

The hardcoded timeout is causing intermittent failures on our tests.

stencil/src/testing/puppeteer/puppeteer-page.ts

Line 263 in 8a18112

await page.waitForFunction('window.stencilAppLoaded', { timeout: 4750 });

Causes:

App did not load in allowed time. Please ensure the content loads a stencil application.
      at waitForStencil (node_modules/@stencil/core/dist/testing/index.js:39878:15)

Adding this as a configurable value would make sense.

[bitflower]

Same here, can we make it configurable?

[bitflower]

Made a PR - for me locally it works from a local build.

I've triggered @adamdbradley on Slack reg. this.

[rwaskiewicz]

Closing, as this appears to have been fixed in 8b69731. If the problem is still occurring, please feel free to open a new issue. Thanks!