feat(cli): [STENCIL-33] Writing and Reading the Ionic config file #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltm
reviewed
Jul 14, 2021
rwaskiewicz
reviewed
Jul 14, 2021
|
@rwaskiewicz Added 6 tests for these new methods. |
ltm
reviewed
Jul 14, 2021
rwaskiewicz
reviewed
Jul 14, 2021
Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
rwaskiewicz
reviewed
Jul 15, 2021
ltm
reviewed
Jul 15, 2021
Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
Co-authored-by: Lars Mikkelsen <lars@ionic.io>
rwaskiewicz
reviewed
Jul 15, 2021
rwaskiewicz
approved these changes
Jul 15, 2021
…gleton to help facilitate accessing features during the CLI's lifecycle.
|
@rwaskiewicz and @ltm if you could take a peek at the new changes in 2dd693f regarding using the abstracted system calls that help us work in Deno or Node I'd really appreciate it! I'm going to bring these over to the STENCIL 12 PR in the meantime. |
rwaskiewicz
reviewed
Jul 21, 2021
Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
splitinfinities
force-pushed
the
chore/telemetry/STENCIL-33-writing-and-reading-config
branch
from
2888409
to
8a40ef6
Compare
rwaskiewicz
approved these changes
Jul 21, 2021
ltm
reviewed
Jul 21, 2021
src/cli/telemetry/helpers.ts
Outdated
Comment on lines
30
to
33
| tty: process.stdout.isTTY ? true : false, | ||
| ci: | ||
| ['CI', 'BUILD_ID', 'BUILD_NUMBER', 'BITBUCKET_COMMIT', 'CODEBUILD_BUILD_ARN'].filter(v => !!process.env[v]) | ||
| .length > 0 || process.argv.includes('--ci'), |
There was a problem hiding this comment.
process is a Node built-in, so you'd have to access these through the compiler system. You should be able to replace process.env[v] with CompilerSystem.getEnvironmentVar(v)
There was a problem hiding this comment.
Ahh, hmm... I'm going to need to do a couple changes here in that case.
ltm
approved these changes
Jul 22, 2021
rwaskiewicz
approved these changes
Jul 23, 2021
rwaskiewicz
deleted the
chore/telemetry/STENCIL-33-writing-and-reading-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to allow writing and reading to the ~/.ionic/config.json file. When reading, if the file doesn't exist, readConfig will automatically create the file.
Satisfies ADR-2