Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): [STENCIL-33] Writing and Reading the Ionic config file #2963

Merged
merged 16 commits into from
Jul 23, 2021
Merged

feat(cli): [STENCIL-33] Writing and Reading the Ionic config file #2963

merged 16 commits into from
Jul 23, 2021

Commits on Jul 13, 2021

  1. feat(cli): [STENCIL-33] Writing and Reading the Ionic config file

    @splitinfinities
    splitinfinities committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    744c9a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Adding feedback from Ryan and Lars

    @splitinfinities
    splitinfinities committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    95b1c91 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. Update src/cli/ionic-config.ts 

    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    @splitinfinities @rwaskiewicz
    splitinfinities and rwaskiewicz committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    2870645 View commit details
    Browse the repository at this point in the history

  2. Update src/cli/telemetry/test/helpers.spec.ts 

    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    @splitinfinities @rwaskiewicz
    splitinfinities and rwaskiewicz committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    f9c2695 View commit details
    Browse the repository at this point in the history

  3. Incorporating feedback from Ryan

    @splitinfinities
    splitinfinities committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    5522419 View commit details
    Browse the repository at this point in the history

  4. Continue to remove external Deps

    @splitinfinities
    splitinfinities committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    74b8c40 View commit details
    Browse the repository at this point in the history

  5. Fixing missed type

    @splitinfinities
    splitinfinities committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    614b0e9 View commit details
    Browse the repository at this point in the history

  6. Update src/cli/telemetry/test/helpers.spec.ts 

    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    @splitinfinities @rwaskiewicz
    splitinfinities and rwaskiewicz committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    c2271df View commit details
    Browse the repository at this point in the history

  7. Update src/cli/telemetry/helpers.ts 

    Co-authored-by: Lars Mikkelsen <lars@ionic.io>
    @splitinfinities @ltm
    splitinfinities and ltm committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    866151c View commit details
    Browse the repository at this point in the history

  8. Adding tests for isInteractive

    @splitinfinities
    splitinfinities committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    71bbea0 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Switching to internal sys calls instead of using packages. Adding sin… 

    …gleton to help facilitate accessing features during the CLI's lifecycle.
    @splitinfinities
    splitinfinities committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    2dd693f View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Update src/cli/telemetry/test/helpers.spec.ts 

    Co-authored-by: Ryan Waskiewicz <ryanwaskiewicz@gmail.com>
    @splitinfinities @rwaskiewicz
    splitinfinities and rwaskiewicz committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    13994a6 View commit details
    Browse the repository at this point in the history

  2. Feedback from Ryan

    @splitinfinities
    splitinfinities committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    8a40ef6 View commit details
    Browse the repository at this point in the history

  3. Feedback from Ryan

    @splitinfinities
    splitinfinities committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2582e3a View commit details
    Browse the repository at this point in the history

  4. Feedback from Ryan

    @splitinfinities
    splitinfinities committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    e5c0313 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Updating the process calls to route through the abstration.

    @splitinfinities
    splitinfinities committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f29642d View commit details
    Browse the repository at this point in the history