Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock-doc): add inert to HTMLAttributes #5072

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

rwaskiewicz
Copy link
Member

What is the current behavior?

The inert attribute fails to type check:
Screenshot 2023-11-14 at 9 10 35 AM

fixes: #5071

What is the new behavior?

add inert to the HTMLAttributes interface. this change only allows the attribute to properly type check in TSX. it does not polyfill the functionality for browsers that do not support inert.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Check out and build this branch:

npm ci \
&& npm run clean \
&& npm run build \
&& npm pack

Install it in the output of creating a new stencil component library:

cd /tmp \
&& npm init stencil@latest component inert-test \
&& cd $_ \
&& npm i [PATH_TO_STENCIL]

Open src/components/my-component/my-component.tsx in your editor, and inert to a JSX element. It should not properly type check:

Screenshot 2023-11-14 at 9 12 27 AM

Other information

STENCIL-1011 bug: Property 'inert' does not exist on type 'HTMLAttributes'

add `inert` to the `HTMLAttributes` interface. this change only allows
the attribute to properly type check in TSX. it does not polyfill the
functionality for browsers that do not support `inert`.

STENCIL-1011 bug: Property 'inert' does not exist on type 'HTMLAttributes<HTMLXElement>'

fixes: #5071
Copy link
Contributor

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1381 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files
Path Error Count
src/dev-server/index.ts 37
src/mock-doc/serialize-node.ts 36
src/dev-server/server-process.ts 32
src/compiler/build/build-stats.ts 27
src/compiler/output-targets/dist-lazy/generate-lazy-module.ts 25
src/compiler/style/test/optimize-css.spec.ts 23
src/testing/puppeteer/puppeteer-element.ts 23
src/compiler/prerender/prerender-main.ts 22
src/runtime/client-hydrate.ts 19
src/screenshot/connector-base.ts 19
src/runtime/vdom/vdom-render.ts 18
src/compiler/config/test/validate-paths.spec.ts 16
src/dev-server/request-handler.ts 15
src/compiler/prerender/prerender-optimize.ts 14
src/compiler/sys/stencil-sys.ts 14
src/compiler/transpile/transpile-module.ts 14
src/runtime/vdom/vdom-annotations.ts 14
src/sys/node/node-sys.ts 14
src/compiler/build/build-finish.ts 13
src/compiler/prerender/prerender-queue.ts 13
Our most common errors
Typescript Error Code Count
TS2345 412
TS2322 391
TS18048 310
TS18047 100
TS2722 38
TS2532 34
TS2531 23
TS2454 14
TS2352 13
TS2769 10
TS2790 10
TS2538 8
TS2344 5
TS2416 4
TS2493 3
TS2488 2
TS18046 2
TS2684 1
TS2430 1

Unused exports report

There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports
File Line Identifier
src/runtime/bootstrap-lazy.ts 21 setNonce
src/screenshot/screenshot-fs.ts 18 readScreenshotData
src/testing/testing-utils.ts 198 withSilentWarn
src/utils/index.ts 145 CUSTOM
src/utils/index.ts 269 normalize
src/utils/index.ts 7 escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts 25 BUILD
src/compiler/app-core/app-data.ts 115 Env
src/compiler/app-core/app-data.ts 117 NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts 123 updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts 61 satisfies
src/compiler/types/validate-primary-package-output-target.ts 61 Record
src/testing/puppeteer/puppeteer-declarations.ts 485 WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts 7 writeFetchSuccessSync

@rwaskiewicz rwaskiewicz marked this pull request as ready for review November 14, 2023 14:49
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner November 14, 2023 14:49
@rwaskiewicz rwaskiewicz added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 71a4110 Nov 14, 2023
120 checks passed
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/fix/inert branch November 14, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Property 'inert' does not exist on type 'HTMLAttributes<HTMLXElement>'
3 participants