Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document data-resources-url #903

Closed
rbrcurtis opened this issue Jul 5, 2018 · 5 comments
Closed

document data-resources-url #903

rbrcurtis opened this issue Jul 5, 2018 · 5 comments
Assignees
Labels
ionitron: stale issue This issue has not seen any activity for a long period of time

Comments

@rbrcurtis
Copy link

rbrcurtis commented Jul 5, 2018

I'm submitting a:

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://stencil-worldwide.slack.com

I've been playing with stencil and other WC frameworks looking for one that fits my needs. Stencil is pretty awesome but one of my struggles has been with specifying where to load resources from so that lazy loading works correctly (we load js assets from a CDN). I found data-resources-url in your loader code which is perfect, but see that it isn't documented anywhere.

I'm a bit hesitant to make use of it as I'd consider it "private" unless its documented.

@ionitron-bot ionitron-bot bot added the triage label Jul 5, 2018
@jthoms1 jthoms1 self-assigned this Jul 9, 2018
@jthoms1
Copy link
Member

jthoms1 commented Jul 9, 2018

Hopefully you should not need to use data-resources-url. This is definitely an internal use mechanism. How are you loading assets other than components? Do you have some example code so that I could get a better understanding?

@jthoms1 jthoms1 added Awaiting Reply This PR or Issue needs a reply from the original reporter. and removed triage labels Jul 9, 2018
@rbrcurtis
Copy link
Author

We host all our js and css assets on a CDN so our script tags are all pointing to that. We also pull some common libs, such as bootstrap, from public CDNs. So we've got script tags which src several different hostnames.

What is the preferred method to tell any given stencil WC lib where to do its loading from?

@jthoms1
Copy link
Member

jthoms1 commented Jul 10, 2018

Ok, so in most cases the resource location can be figured out by stencil but apparently there are some cases where 'data-resources-url' is needed. So with a little more research it turns out that this is not only an internal use mechanism and is just lacking documentation.

So if it works use it. I will change this issue to a docs issue so we need to document when to make use of this mechanism

@jthoms1 jthoms1 added documentation needed and removed Awaiting Reply This PR or Issue needs a reply from the original reporter. labels Jul 10, 2018
@rbrcurtis
Copy link
Author

rbrcurtis commented Jul 10, 2018 via email

@ionitron-bot ionitron-bot bot added the ionitron: stale issue This issue has not seen any activity for a long period of time label Aug 9, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Aug 9, 2018

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Aug 9, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ionitron: stale issue This issue has not seen any activity for a long period of time
Projects
None yet
Development

No branches or pull requests

2 participants