Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime): prevent watchers from prematurely firing in custom elements build #2971

Merged
merged 3 commits into from
Jul 21, 2021
Merged

fix(runtime): prevent watchers from prematurely firing in custom elements build #2971

merged 3 commits into from
Jul 21, 2021

Commits on Jul 20, 2021

  1. fix(runtime): prevent watchers from prematurely firing in custom elem… 

    …ent build

- wait for a component to be defined in the CustomElementsRegistry
  before setting the isWatchReady flag
    @rwaskiewicz
    rwaskiewicz committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    2ccbfea View commit details
    Browse the repository at this point in the history

  2. - add misc comments added while reading the codebase

    @rwaskiewicz
    rwaskiewicz committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    629050b View commit details
    Browse the repository at this point in the history

  3. - add documentation to fix

    @rwaskiewicz
    rwaskiewicz committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    53d1753 View commit details
    Browse the repository at this point in the history