Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(emit): don't emit test files #5789

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(emit): don't emit test files #5789

merged 1 commit into from
Jun 4, 2024
+9 −7

Commits on Jun 3, 2024

  1. fix(emit): don't emit test files 

    This fixes a bug introduced in #4315, which upgraded to TypeScript 5. In
that PR we had to change the way that we prevented certain files from
being emitted by the typescript compiler because in the 5.0 release our
previous approach stopped working.

However, in porting over to a new approach that worked with TS 5.0 there
was an oversight. I misunderstood the intent of the old code as being to
merely prevent writing `.d.ts` files in the output, when actually it was
about preventing the compiled JavaScript from being written for
`.e2e.ts` and `.spec.ts` files.

This change ensures that we no longer emit these files.

fixes #5788
STENCIL-1325
    @alicewriteswrongs
    alicewriteswrongs committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    715f36c View commit details
    Browse the repository at this point in the history