configure: applicationId in build.gradle stays unchanged

[tobiasmuecksch]

Current behavior

When running cap-configure it seems to ignore the applicationId for android

plaftorm-config.yml

vars:
  PACKAGE_NAME_ANDROID:
    default: com.capconfigure.demoandroid

  android:
    packageName: $PACKAGE_NAME_ANDROID
    versionName: 2.2.2
    versionCode: 222

Version

I observed this behavior in version 1.0.20

Reproduction

I've created a demo repo for you to quickly reproduce.

https://github.com/tobiasmuecksch/cap-configure-problem-demo

1. clone repo
2. run npm run init
   • Info: This task installs npm packages, adds the ios and android platforms and runs cap-configure

Then check the android/app/build.gradle-file, and you'll see, that the applicationId is not updated correctly.

[mlynch]

Okay I need to add that as it's currently only change the package name in the AndroidManifest.xml

[ksteuer]

Hi @mlynch. Do you think we could also implement changing the package name in MainActivity.java (and other classes if exist) and its parent directory according to provided bundleId?

[mlynch]

Yes, definitely. Perhaps I'll roll these two into a single task

[ksteuer]

The first one should be done in my recent PR. I will try to take care of the second one in the following days.

[mlynch]

Awesome! Left a comment on the PR. I wasn't expecting a PR so I had already started on this and the package folder rename. If I get it wrapped up here shortly I'll let you know otherwise you can go ahead

[ksteuer]

OK! I will have more time tomorrow evening and over the weekend. If you had already started I can take care of another issue though.

[mlynch]

I'll throw up my first pass as a PR and would like your input!

[mlynch]

@ksteuer #35 would love your feedback/testing/input!