feat(rules): add ion-menu-toggle-is-now-an-element rule

README.md

@@ -365,11 +365,13 @@ We are looking for contributors to help build these rules out! See [`CONTRIBUTIN
       <a href="https://github.com/ionic-team/ionic/blob/master/angular/BREAKING.md#menu-toggle">Menu Toggle</a>
     </th>
     <td></td>
-    <td>:white_large_square:</td>
+    <td>:white_check_mark:</td>
     <td>
       <code>ion-menu-toggle-is-now-an-element</code>
     </td>
-    <td></td>
+    <td>
+      <a href="https://github.com/dwieeb">@dwieeb</a>
+    </td>
   </tr>
   <tr>
     <th>

src/ionMenuToggleIsNowAnElementRule.ts

@@ -0,0 +1,6 @@
+import { createDirectiveToElementRuleClass } from './helpers/directiveToElement';
+
+const directive = 'menuToggle';
+
+export const ruleName = 'ion-menu-toggle-is-now-an-element';
+export const Rule = createDirectiveToElementRuleClass(ruleName, directive, 'ion-menu-toggle');

test/ionMenuToggleIsNowAnElement.spec.ts

@@ -0,0 +1,78 @@
+import { ruleName } from '../src/ionMenuToggleIsNowAnElementRule';
+import { assertAnnotated, assertSuccess } from './testHelper';
+
+describe(ruleName, () => {
+  describe('success', () => {
+    it('should work with proper style', () => {
+      let source = `
+      @Component({
+        template: \`
+          <ion-menu-toggle>
+            <ion-button>
+              Toggle Menu
+            </ion-button>
+          </ion-menu-toggle>
+        \`
+      })
+      class Bar{}
+        `;
+      assertSuccess(ruleName, source);
+    });
+  });
+
+  describe('failure', () => {
+    it('should fail when menuToggle attribute is used on button', () => {
+      let source = `
+      @Component({
+        template: \`
+          <button ion-button menuToggle>Toggle Menu</button>\`
+                             ~~~~~~~~~~
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'menuToggle is now an ion-menu-toggle element instead of an Angular directive.',
+        source
+      });
+    });
+
+    it('should fail when menuToggle attribute is used on anchor', () => {
+      let source = `
+      @Component({
+        template: \`
+          <a ion-button menuToggle (click)="doSomething()">Toggle Menu</a>\`
+                        ~~~~~~~~~~
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'menuToggle is now an ion-menu-toggle element instead of an Angular directive.',
+        source
+      });
+    });
+
+    it('should fail when ion-button attribute is used with multiline', () => {
+      let source = `
+      @Component({
+        template: \`
+          <a
+            ion-button
+            menuToggle
+            ~~~~~~~~~~
+            (click)="doSomething()">Toggle Menu</a>\`
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'menuToggle is now an ion-menu-toggle element instead of an Angular directive.',
+        source
+      });
+    });
+  });
+});