fix(rules): fix ion-button-is-now-an-element for angular html syntax

ionic-team · Jun 25, 2018 · bb5f631 · bb5f631
1 parent 9122393
commit bb5f631
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/src/ionButtonIsNowAnElementRule.ts b/src/ionButtonIsNowAnElementRule.ts
@@ -10,7 +10,7 @@ export const ruleName = 'ion-button-is-now-an-element';
 class IonButtonIsNowAnElementTemplateVisitor extends BasicTemplateAstVisitor {
   visitElement(element: ast.ElementAst, context: any): any {
     if (element.name) {
-      const InvalidSyntaxBoxRe = /<(\w+)(?:[a-zA-Z\"\=]|\s)*(ion-button)(?:[a-zA-Z\"\=]|\s)*>/gis;
+      const InvalidSyntaxBoxRe = /<\w+[\s\S]+?(ion-button)[\s\S]*?>/gi;
 
       let error = 'Ion Button is now an Element instead of an attribute.';
 

diff --git a/test/IonButtonIsNowAnElement.spec.ts b/test/IonButtonIsNowAnElement.spec.ts
@@ -15,7 +15,7 @@ describe(ruleName, () => {
   });
 
   describe('failure', () => {
-    it('should fail when ion-button-attribute is used', () => {
+    it('should fail when ion-button attribute is used on button', () => {
       let source = `
       @Component({
         template: \`
@@ -31,5 +31,41 @@ describe(ruleName, () => {
         source
       });
     });
+
+    it('should fail when ion-button attribute is used on anchor', () => {
+      let source = `
+      @Component({
+        template: \`
+          <a ion-button (click)="doSomething()"></a>\`
+             ~~~~~~~~~~
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'Ion Button is now an Element instead of an attribute.',
+        source
+      });
+    });
+
+    it('should fail when ion-button attribute is used with multiline', () => {
+      let source = `
+      @Component({
+        template: \`
+          <a
+            ion-button
+            ~~~~~~~~~~
+            (click)="doSomething()">Click Me</a>\`
+      })
+      class Bar{}
+          `;
+
+      assertAnnotated({
+        ruleName,
+        message: 'Ion Button is now an Element instead of an attribute.',
+        source
+      });
+    });
   });
 });