refactor(rules): share template visitor class

src/helpers/directiveToElement.ts

@@ -0,0 +1,32 @@
+import * as ast from '@angular/compiler';
+import { BasicTemplateAstVisitor } from 'codelyzer/angular/templates/basicTemplateAstVisitor';
+
+export function generateDescription(directive: string) {
+  return `${directive} is now an Element instead of an Angular Directive.`;
+}
+
+export function createDirectiveToElementTemplateVisitorClass(directive: string) {
+  return class extends BasicTemplateAstVisitor {
+    visitElement(element: ast.ElementAst, context: any): any {
+      if (element.name) {
+        const InvalidSyntaxBoxRe = new RegExp(`<\\w+[\\s\\S]+?(${directive})[\\s\\S]*?>`, 'gi');
+
+        let error = generateDescription(directive);
+
+        const expr = element.sourceSpan.toString();
+
+        let matches;
+
+        while ((matches = InvalidSyntaxBoxRe.exec(expr)) !== null) {
+          const index = expr.indexOf(directive);
+          const start = element.sourceSpan.start.offset + index;
+          const absolutePosition = this.getSourcePosition(start - 1);
+
+          this.addFailure(this.createFailure(start, directive.length, error));
+        }
+      }
+
+      super.visitElement(element, context);
+    }
+  };
+}

src/ionButtonIsNowAnElementRule.ts

@@ -1,45 +1,24 @@
-import * as ast from '@angular/compiler';
 import { NgWalker } from 'codelyzer/angular/ngWalker';
-import { BasicTemplateAstVisitor } from 'codelyzer/angular/templates/basicTemplateAstVisitor';
 import * as Lint from 'tslint';
 import { IOptions } from 'tslint';
 import * as ts from 'typescript';
 
-export const ruleName = 'ion-button-is-now-an-element';
-
-class IonButtonIsNowAnElementTemplateVisitor extends BasicTemplateAstVisitor {
-  visitElement(element: ast.ElementAst, context: any): any {
-    if (element.name) {
-      const InvalidSyntaxBoxRe = /<\w+[\s\S]+?(ion-button)[\s\S]*?>/gi;
-
-      let error = 'Ion Button is now an Element instead of an attribute.';
-
-      const expr: any = (<any>element.sourceSpan).toString();
-
-      let matches;
+import { createDirectiveToElementTemplateVisitorClass, generateDescription } from './helpers/directiveToElement';
 
-      while ((matches = InvalidSyntaxBoxRe.exec(expr)) !== null) {
-        const index = expr.indexOf('ion-button');
-        const start = element.sourceSpan.start.offset + index;
-        const absolutePosition = this.getSourcePosition(start - 1);
-
-        this.addFailure(this.createFailure(start, 10, error));
-      }
-    }
+const directive = 'ion-button';
+export const ruleName = 'ion-button-is-now-an-element';
 
-    super.visitElement(element, context);
-  }
-}
+const IonButtonIsNowAnElementTemplateVisitor = createDirectiveToElementTemplateVisitorClass(directive);
 
 export class Rule extends Lint.Rules.AbstractRule {
   public static metadata: Lint.IRuleMetadata = {
     ruleName: ruleName,
     type: 'functionality',
-    description: 'Ion Button is now an Element instead of an attribute.',
+    description: generateDescription(directive),
     options: null,
     optionsDescription: 'Not configurable.',
     typescriptOnly: false,
-    hasFix: true
+    hasFix: false
   };
 
   constructor(options: IOptions) {

test/ionButtonIsNowAnElement.spec.ts

@@ -27,7 +27,7 @@ describe(ruleName, () => {
 
       assertAnnotated({
         ruleName,
-        message: 'Ion Button is now an Element instead of an attribute.',
+        message: 'ion-button is now an Element instead of an Angular Directive.',
         source
       });
     });
@@ -44,7 +44,7 @@ describe(ruleName, () => {
 
       assertAnnotated({
         ruleName,
-        message: 'Ion Button is now an Element instead of an attribute.',
+        message: 'ion-button is now an Element instead of an Angular Directive.',
         source
       });
     });
@@ -63,7 +63,7 @@ describe(ruleName, () => {
 
       assertAnnotated({
         ruleName,
-        message: 'Ion Button is now an Element instead of an attribute.',
+        message: 'ion-button is now an Element instead of an Angular Directive.',
         source
       });
     });