Support .then() in ion-overlay-method-*-should-use-await rule

[JesperBalslev]

When changing overlay components (Loading, Toast, Modal, or Alert ) to v4, which are created asynchronously now, the tslint migration still gives an error when you write it like this:

showAlert() {
  this.alertCtrl.create({
    message: "Hello There",
    subHeader: "I'm a subheader"
  }).then(alert => alert.present());
}

giving this error:

 The create method of overlay controllers now returns a promise.
Please ensure that you are handling this promise correctly.

[imhoffd]

Thanks @JesperBalslev. We should probably just make that a warning, not an error.

I think if you do this, it may not complain:

async showAlert() {
  const alert = await this.alertCtrl.create({
    message: "Hello There",
    subHeader: "I'm a subheader"
  });

  await alert.present();
}

We just need to add logic to check for a .then() call as well

[JesperBalslev]

Thanks for the reply, that is true. :)
I just prefer to write it the other way... unless there is a reason i shouldn't?

[imhoffd]

No reason, it's a preference! We should handle both ways. 😄

[godenji]

Linter output is kind of noisy with these false positives...

[Ionitron]

🎉 This issue has been resolved in version 1.6.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀