Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rules): uncombine ion-navbar-is-now-ion-toolbar rule #38

Merged
merged 3 commits into from
Jul 7, 2018
Merged

fix(rules): uncombine ion-navbar-is-now-ion-toolbar rule #38

merged 3 commits into from
Jul 7, 2018

Commits on Jul 7, 2018

  1. fix(rules): uncombine ion-navbar-is-now-ion-toolbar rule 

    Previously the rule was adding an ion-back-button (and container) as
well as changing the tag names to ion-toolbar.

We have a rule for warning about the missing back button: `ion-back-button-not-added-by-default`

It's probably best to keep these separated for simplicity
    @imhoffd
    imhoffd committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    7d07ad9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into bugfix/uncombine-navbar-rule

    @imhoffd
    imhoffd committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    19f6abd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into bugfix/uncombine-navbar-rule

    @imhoffd
    imhoffd committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    8f5874f View commit details
    Browse the repository at this point in the history