Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PascalCase identifiers #148

Closed
haf opened this issue Aug 24, 2016 · 7 comments
Closed

PascalCase identifiers #148

haf opened this issue Aug 24, 2016 · 7 comments

Comments

@haf
Copy link

haf commented Aug 24, 2016

Hi there,

I would prefer camelCase identifiers. Who decided it should be PascalCase? Nowadays ionide complains and I'm enforcing camelCase throughout my projects.

Regards,
Henrik

Moved from https://github.com/ionide/ionide-atom-fsharp/issues/251

@cloudRoutine
Copy link
Member

this linting rule is from FSharplint, @duckmatt wrote it
I turn it off, you can too

    // Enables integration with FSharpLinter (additional warnigns)
    "FSharp.linter": false,

If @Krzysztof-Cieslak had included settings support you could turn off that particular rule, but he did not

@haf
Copy link
Author

haf commented Aug 24, 2016

Thanks

@Krzysztof-Cieslak
Copy link
Member

Krzysztof-Cieslak commented Aug 24, 2016

If @Krzysztof-Cieslak had included settings support you could turn off that particular rule, but he did not

I included settings support, you can turn off rules using FSharpLint setting file.

@dsyme
Copy link
Contributor

dsyme commented Sep 13, 2016

Hi @Krzysztof-Cieslak,

I just saw someone hit this problem (see fsprojects/FSharpLint#180).

There are three things I see

  • The FSharpLint message is too strong. It says you mut use Pascal case identifiers. This should say something softer like "suggest".
  • In Ionide, FSharpLint error messages should have text indicating that they are from FSharpLint. Currently they look like they are coming from F# proper. I know they use green squigglies - but beginners don't know that.
  • Also it would be very helpful to have Ionide automatically add some help text explaining how to adjust FSharpLint settings

Cheers
don

@Krzysztof-Cieslak
Copy link
Member

This is fixed in 2.5.3 - new version of FSharpLint includes new warning messages and we know add information that warning comes from Linter.

Also it would be very helpful to have Ionide automatically add some help text explaining how to adjust FSharpLint settings

I will consider it, not yet sure how to do this way without putting too intrusive messages.

@dsyme
Copy link
Contributor

dsyme commented Sep 30, 2016

@Krzysztof-Cieslak Thanks!

@ImaginaryDevelopment
Copy link

I'd really like to be able to disable specific Linter rules, specifically for Fable.
Example:

    type IJQuery =
        abstract css : string * string -> IJQuery
        abstract addClass : string -> IJQuery
        [<Emit("$0.click($1)")>]
        abstract click : (obj -> unit) -> IJQuery
        [<Emit("$0.click()")>]
        abstract click : unit -> IJQuery
        [<Emit("$0.on('click', $1)")>]
        abstract onClick : (obj -> unit) -> IJQuery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants