-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug flag to get stack traces on mono #565
Conversation
helps with stacktraces like this:
|
CC: @enricosada Will it have impact on anything else? |
The mono docs mention that it does have an impact on performance to run with debug information enabled, but i think it's a small price to pay to get mono users on parity with Windows users. Windows stacktraces are always enabled, lucky ducks |
Not sure what that All that is needed for better stack traces is either .mdb files or portable pdb files next to the executables / libraries. On Mono, old style Windows pdb files don't work and you get these Makes no difference if the exe is compiled as Release or Debug. |
Looks like the issue here is that ProjectCrackerTool is using the Windows pdb file format. |
ah geez, I am dumb. I put the @nosami this is specifically around stack traces for FSAC. So if we bundled .mdb and/or portable pdbs in the Ionide extension directory here, we'd get better traces for FSAC itself?
|
yep! You need an Hopefully, portable pdb adoption will become the norm as it works cross platform. |
I think we can handle it as part - ionide/FsAutoComplete#224. When we will move FSAC to SDK based project files we will be able to generate portable pdbs easily. Then we could distribute them with Ionide without any problem. CC: @enricosada |
I was just going to suggest that, @Krzysztof-Cieslak. I'm ok with closing this issue in light of that :) |
if you add --debug then your stack traces have line numbers, yay!